From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] Make default invocation of block drivers safer
Date: Thu, 15 Jul 2010 10:09:08 +0200 [thread overview]
Message-ID: <4C3EC224.8020309@redhat.com> (raw)
In-Reply-To: <20100714184311.GA9383@lst.de>
Am 14.07.2010 20:43, schrieb Christoph Hellwig:
> Err, strong NACK. Please don't start messing with the contents of the
> data plane, we're getting into real trouble there. It's perfectly
> valid for a guest to create an image inside an image, and with hardware
> support for nested virtualization I guess this use case will become
> rather common, just as it already is on S/390 with VM.
But you'll hardly ever find a legitimate or even common use case for
putting qcow2 on a raw hard disk. I mean, we have all learned that qcow2
can be used in LVs (which can grow at least), but directly on a hard
disk just doesn't make any sense to me. That's the first point.
The second is that you should always specify the format explicitly,
which turns this magic off. Specify format=raw and you're free to format
as many hard disks as qcow2 as you want.
Third, if you don't specify format=raw and the guest has written a qcow2
header, next time it would get the wrong content anyway because qcow2
will be interpreted by the host and not the level 1 guest (this one is
the security problem).
Kevin
next prev parent reply other threads:[~2010-07-15 8:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 16:12 [Qemu-devel] [PATCH] Make default invocation of block drivers safer Anthony Liguori
2010-07-14 16:42 ` [Qemu-devel] " Kevin Wolf
2010-07-14 17:40 ` Anthony Liguori
2010-07-15 8:00 ` Kevin Wolf
2010-07-14 18:43 ` [Qemu-devel] " Christoph Hellwig
2010-07-14 18:50 ` Anthony Liguori
2010-07-15 9:20 ` Daniel P. Berrange
2010-07-15 12:35 ` Anthony Liguori
2010-07-15 15:19 ` Markus Armbruster
2010-07-15 16:20 ` Anthony Liguori
2010-07-15 17:10 ` Kevin Wolf
2010-07-15 17:51 ` Anthony Liguori
2010-07-16 7:30 ` Kevin Wolf
2010-07-16 12:55 ` Stefan Hajnoczi
2010-07-16 13:00 ` Stefan Hajnoczi
2010-07-16 16:06 ` Markus Armbruster
2010-07-16 16:16 ` Anthony Liguori
2010-07-16 16:24 ` Kevin Wolf
2010-07-14 18:53 ` Anthony Liguori
2010-07-14 18:54 ` Aurelien Jarno
2010-07-14 19:04 ` Anthony Liguori
2010-07-15 8:09 ` Kevin Wolf [this message]
2010-07-15 9:10 ` Stefan Hajnoczi
2010-07-15 12:57 ` Anthony Liguori
2010-07-15 13:16 ` Kevin Wolf
2010-07-15 13:20 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3EC224.8020309@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).