From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37606 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OZlp7-0001xB-UO
	for qemu-devel@nongnu.org; Fri, 16 Jul 2010 10:23:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OZlov-0004Tb-Cs
	for qemu-devel@nongnu.org; Fri, 16 Jul 2010 10:23:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63444)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OZlov-0004TM-59
	for qemu-devel@nongnu.org; Fri, 16 Jul 2010 10:23:21 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6GENJRb026454
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 16 Jul 2010 10:23:19 -0400
Message-ID: <4C406B55.7000506@redhat.com>
Date: Fri, 16 Jul 2010 16:23:17 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <20100716141146.GA4325@redhat.com>
In-Reply-To: <20100716141146.GA4325@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] vhost: fix miration during device start
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On 07/16/10 16:11, Michael S. Tsirkin wrote:
> We need to know ring layout to allocate log buffer.
> So init rings first.
>
> Also fixes a theoretical memory-leak-on-error.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=615228
>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>

Fixes the bug for me.

Tested-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
   Gerd