From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43499 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OasH1-0004SZ-AA
	for qemu-devel@nongnu.org; Mon, 19 Jul 2010 11:28:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OasH0-0000J7-73
	for qemu-devel@nongnu.org; Mon, 19 Jul 2010 11:28:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:24749)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OasGz-0000Iv-VP
	for qemu-devel@nongnu.org; Mon, 19 Jul 2010 11:28:54 -0400
Message-ID: <4C446F28.7070201@redhat.com>
Date: Mon, 19 Jul 2010 17:28:40 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1279547615-25599-1-git-send-email-aurelien@aurel32.net>
In-Reply-To: <1279547615-25599-1-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] ide/atapi: add support for GET EVENT
	STATUS NOTIFICATION
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Am 19.07.2010 15:53, schrieb Aurelien Jarno:
> The GET EVENT STATUS NOTIFICATION is a mandatory command according
> to MMC-3, even if event status notification is not supported.
> 
> This patch adds support for this command. It returns NEA ("No Event
> Available") with an empty "Supported Event Classes" to show that it
> doesn't event support status notification. If asychronous operation is
> requested, which requires NCQ support, it returns an error according
> to the specifications.
> 
> This fixes HAL support on FreeBSD and derivatives, which fill up the
> logs every second with:
> 
>   acd0: FAILURE - unknown CMD (0x03) ILLEGAL REQUEST asc=0x20 ascq=0x00
> 
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Looks good to me.

Would you prefer me to take this into the block branch (actually, I have
already done this) or are you going to commit directly? This might
actually be something that should be in 0.13.

Have you tested some more OSes to ensure that they don't start to expect
events to actually work now the command "works"? I didn't see any
problems in a quick test with Linux, but you never know.

Kevin