From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42027 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObFTd-0003uZ-Ia for qemu-devel@nongnu.org; Tue, 20 Jul 2010 12:15:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObFQi-0007Qr-Dq for qemu-devel@nongnu.org; Tue, 20 Jul 2010 12:12:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1026) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObFQi-0007Qj-5P for qemu-devel@nongnu.org; Tue, 20 Jul 2010 12:12:28 -0400 Message-ID: <4C45CAE5.6030603@redhat.com> Date: Tue, 20 Jul 2010 18:12:21 +0200 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] Disable O_DIRECT for physical CDROM/DVD drives References: <1279639056-20465-1-git-send-email-Jes.Sorensen@redhat.com> <4C45C355.2000204@codemonkey.ws> <4C45CA49.6080901@redhat.com> In-Reply-To: <4C45CA49.6080901@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On 07/20/10 18:09, Kevin Wolf wrote: > Am 20.07.2010 17:40, schrieb Anthony Liguori: >> Wouldn't a better solution be to have a cdrom_read/cdrom_write hook that >> did the appropriate bouncing? > > We already have code that does some bouncing, we'd just need to teach it > to use different sizes than 512. Duplicating everything wouldn't be a > nice solution. The problem is that it is quite hard to detect properly and there are cases where we can get false positives, plus it would require cleaning up the code to handle variable sector sizes. The latter is probably a good thing, and if/when it happens, we can remove this. Cheers, Jes