From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51482 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObFYZ-0000n4-GL for qemu-devel@nongnu.org; Tue, 20 Jul 2010 12:20:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObFY8-0000K8-LY for qemu-devel@nongnu.org; Tue, 20 Jul 2010 12:20:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11207) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObFY8-0000Jx-Bw for qemu-devel@nongnu.org; Tue, 20 Jul 2010 12:20:08 -0400 Message-ID: <4C45CCB5.7050503@redhat.com> Date: Tue, 20 Jul 2010 18:20:05 +0200 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] Disable O_DIRECT for physical CDROM/DVD drives References: <1279639056-20465-1-git-send-email-Jes.Sorensen@redhat.com> <4C45C355.2000204@codemonkey.ws> <4C45C87C.4060709@redhat.com> <4C45CBF8.40400@cisco.com> In-Reply-To: <4C45CBF8.40400@cisco.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "David S. Ahern" Cc: qemu-devel@nongnu.org On 07/20/10 18:16, David S. Ahern wrote: > What about setting the logical and physical block size properties? Is > the intent of these to handle varying sizes amongst block devices? > > David Well the problem is that we need to know the sector size of the host device, and then start using that within QEMU for anything using O_DIRECT. The way the QEMU code handles it right now is by hard coding it, and cleaning that up could be a bit messy, but it should go on the todo list. Cheers, Jes