From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57689 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObFwU-0004c1-LI for qemu-devel@nongnu.org; Tue, 20 Jul 2010 12:45:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObFwR-0004PR-B7 for qemu-devel@nongnu.org; Tue, 20 Jul 2010 12:45:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40678) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObFwR-0004P8-0w for qemu-devel@nongnu.org; Tue, 20 Jul 2010 12:45:15 -0400 Message-ID: <4C45D26E.7080109@redhat.com> Date: Tue, 20 Jul 2010 18:44:30 +0200 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Error on O_DIRECT for physical CDROM/DVD drives References: <1279642177-21229-1-git-send-email-Jes.Sorensen@redhat.com> <4C45D03E.3090706@cisco.com> In-Reply-To: <4C45D03E.3090706@cisco.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "David S. Ahern" Cc: qemu-devel@nongnu.org On 07/20/10 18:35, David S. Ahern wrote: > On 07/20/10 10:09, Jes.Sorensen@redhat.com wrote: >> diff --git a/block/raw-posix.c b/block/raw-posix.c >> index 291699f..1b840c4 100644 >> --- a/block/raw-posix.c >> +++ b/block/raw-posix.c >> @@ -1139,6 +1139,11 @@ static int cdrom_open(BlockDriverState *bs, const char *filename, int flags) >> BDRVRawState *s = bs->opaque; >> >> s->type = FTYPE_CD; >> + if (flags & BDRV_O_NOCACHE) { >> + fprintf(stderr, "O_DIRECT (cache=none) for CDROM/DVD device (%s) " >> + "is unsupported\n", filename); >> + exit(1); >> + } > > If a cdrom is added via the monitor this would abruptly terminate the VM > - which is not good. True, but this would only happen if the user explicitly marks it cache=none which is not the default value for a new drive, so it would be a corner case. Cheers, Jes