From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Natalia Portillo <claunia@claunia.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Disable O_DIRECT for physical CDROM/DVD drives
Date: Tue, 20 Jul 2010 18:48:53 +0200 [thread overview]
Message-ID: <4C45D375.9060107@redhat.com> (raw)
In-Reply-To: <78CCC2B7-3124-4B24-9A96-771B8A6D4C27@claunia.com>
On 07/20/10 18:45, Natalia Portillo wrote:
> El 20/07/2010, a las 16:17, Jes.Sorensen@redhat.com escribió:
>
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> O_DIRECT (cache=none) requires sector alignment, however the physical
>> sector size of CDROM/DVD drives is 2048, as opposed to most disk
>> devices which use 512. QEMU is hard coding 512 all over the place, so
>> allowing O_DIRECT for CDROM/DVD devices does not work.
>
> What about if the device is a 4096 byte/sector hard disk, a 512 byte/sector CD-ROM (IRIX ones), a 2048 byte/sector magnetooptical?
>
> We should get rid of that hard codes and use real values.
I totally agree! However for now my patch throws an error for the CDROM
case, which is better than the old situation. We need to fix it in
general, but it isn't trivial. The 4096 sector size hard disk going to
be the main issue.
Jes
next prev parent reply other threads:[~2010-07-20 16:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 15:17 [Qemu-devel] [PATCH] Disable O_DIRECT for physical CDROM/DVD drives Jes.Sorensen
2010-07-20 15:40 ` Kevin Wolf
2010-07-20 16:04 ` Jes Sorensen
2010-07-20 16:12 ` Kevin Wolf
2010-07-20 16:18 ` Jes Sorensen
2010-07-20 15:40 ` [Qemu-devel] " Anthony Liguori
2010-07-20 16:02 ` Jes Sorensen
2010-07-20 16:03 ` Anthony Liguori
2010-07-20 16:06 ` Jes Sorensen
2010-07-20 16:16 ` David S. Ahern
2010-07-20 16:20 ` Jes Sorensen
2010-07-20 16:09 ` Kevin Wolf
2010-07-20 16:12 ` Jes Sorensen
2010-07-20 16:45 ` [Qemu-devel] " Natalia Portillo
2010-07-20 16:48 ` Jes Sorensen [this message]
2010-07-20 17:57 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C45D375.9060107@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=claunia@claunia.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).