From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, "David S. Ahern" <daahern@cisco.com>
Subject: Re: [Qemu-devel] [PATCH] Error on O_DIRECT for physical CDROM/DVD drives
Date: Wed, 21 Jul 2010 09:47:23 +0200 [thread overview]
Message-ID: <4C46A60B.4040700@redhat.com> (raw)
In-Reply-To: <m3fwzekr5g.fsf@blackfin.pond.sub.org>
On 07/20/10 19:19, Markus Armbruster wrote:
> Jes Sorensen <Jes.Sorensen@redhat.com> writes:
>
>> On 07/20/10 18:35, David S. Ahern wrote:
>>> On 07/20/10 10:09, Jes.Sorensen@redhat.com wrote:
>>> If a cdrom is added via the monitor this would abruptly terminate the VM
>>> - which is not good.
>>
>> True, but this would only happen if the user explicitly marks it
>> cache=none which is not the default value for a new drive, so it would
>> be a corner case.
>
> Why not return -ENOTSUP?
Good point, just posted v3 of the patch that does this instead of exit()
Jes
prev parent reply other threads:[~2010-07-21 7:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 16:09 [Qemu-devel] [PATCH] Error on O_DIRECT for physical CDROM/DVD drives Jes.Sorensen
2010-07-20 16:35 ` David S. Ahern
2010-07-20 16:44 ` Jes Sorensen
2010-07-20 17:19 ` Markus Armbruster
2010-07-21 7:47 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C46A60B.4040700@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=armbru@redhat.com \
--cc=daahern@cisco.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).