From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35528 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ObU1Z-0002MA-5O
	for qemu-devel@nongnu.org; Wed, 21 Jul 2010 03:47:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1ObU1X-0006bh-Dl
	for qemu-devel@nongnu.org; Wed, 21 Jul 2010 03:47:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28501)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1ObU1X-0006bV-4P
	for qemu-devel@nongnu.org; Wed, 21 Jul 2010 03:47:27 -0400
Message-ID: <4C46A60B.4040700@redhat.com>
Date: Wed, 21 Jul 2010 09:47:23 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Error on O_DIRECT for physical CDROM/DVD
	drives
References: <1279642177-21229-1-git-send-email-Jes.Sorensen@redhat.com>	<4C45D03E.3090706@cisco.com>
	<4C45D26E.7080109@redhat.com>
	<m3fwzekr5g.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3fwzekr5g.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, "David S. Ahern" <daahern@cisco.com>

On 07/20/10 19:19, Markus Armbruster wrote:
> Jes Sorensen <Jes.Sorensen@redhat.com> writes:
> 
>> On 07/20/10 18:35, David S. Ahern wrote:
>>> On 07/20/10 10:09, Jes.Sorensen@redhat.com wrote:
>>> If a cdrom is added via the monitor this would abruptly terminate the VM
>>> - which is not good.
>>
>> True, but this would only happen if the user explicitly marks it
>> cache=none which is not the default value for a new drive, so it would
>> be a corner case.
> 
> Why not return -ENOTSUP?

Good point, just posted v3 of the patch that does this instead of exit()

Jes