From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38492 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Obe45-0007bd-F3 for qemu-devel@nongnu.org; Wed, 21 Jul 2010 14:30:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Obe3S-0002ln-Q9 for qemu-devel@nongnu.org; Wed, 21 Jul 2010 14:30:07 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:62801) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Obe3S-0002lc-Nt for qemu-devel@nongnu.org; Wed, 21 Jul 2010 14:30:06 -0400 Received: by gwj21 with SMTP id 21so3876844gwj.4 for ; Wed, 21 Jul 2010 11:30:05 -0700 (PDT) Message-ID: <4C473CAC.9050001@codemonkey.ws> Date: Wed, 21 Jul 2010 13:30:04 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1279558287-9446-1-git-send-email-miguel.filho@gmail.com> <1279558287-9446-3-git-send-email-miguel.filho@gmail.com> <20100721144228.07969f8a@redhat.com> <20100721175119.GN21281@redhat.com> In-Reply-To: <20100721175119.GN21281@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v3 2/2] monitor: Convert 'info qdm' to QMP List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: armbru@redhat.com, avi@redhat.com, Miguel Di Ciurcio Filho , qemu-devel@nongnu.org, Luiz Capitulino On 07/21/2010 12:51 PM, Daniel P. Berrange wrote: > On Wed, Jul 21, 2010 at 02:42:28PM -0300, Luiz Capitulino wrote: > >> On Mon, 19 Jul 2010 13:51:27 -0300 >> Miguel Di Ciurcio Filho wrote: >> >> >>> Converts the 'info qdm' command to QMP, allowing the discovery of all devices >>> known to the QEMU binary without relying on command line paramaters like >>> -device ? and -device devtype,? >>> >>> This change does not modify the output of the 'info qdm' monitor command. >>> >>> Signed-off-by: Miguel Di Ciurcio Filho >>> diff --git a/monitor.c b/monitor.c >>> index 45fd482..66810f2 100644 >>> --- a/monitor.c >>> +++ b/monitor.c >>> @@ -2565,7 +2565,8 @@ static const mon_cmd_t info_cmds[] = { >>> .args_type = "", >>> .params = "", >>> .help = "show qdev device model list", >>> - .mhandler.info = do_info_qdm, >>> + .user_print = do_info_qdm_print, >>> + .mhandler.info_new = do_info_qdm, >>> >> Haven't we agreed on calling this query-available-devices or something >> like that? >> > That's getting rather verbose for a name ! How about just > 'query-dev-types' (anticipating future query-netdev-types, > query-chardev-types, commands etc, too) > I know we're still trying to recover from the great bit shortage of '09 but I think we can afford to spare some here to make the names readable :-) Good names are part of good documentation. If it's not entirely obvious what the function does from it's name, it's probably a bad name (in the context of a wire protocol). Regards, Anthony Liguori > > Daniel >