* [Qemu-devel] [PATCH] Use existing config check when including eventfd.h
@ 2010-07-21 23:45 Mike McCormack
2010-07-22 8:11 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Mike McCormack @ 2010-07-21 23:45 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Mike McCormack <mikem@ring3k.org>
---
hw/vhost.c | 2 ++
hw/vhost_net.c | 2 ++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/vhost.c b/hw/vhost.c
index d37a66e..e1cd4d2 100644
--- a/hw/vhost.c
+++ b/hw/vhost.c
@@ -11,7 +11,9 @@
*/
#include <sys/ioctl.h>
+#ifdef CONFIG_EVENTFD
#include <sys/eventfd.h>
+#endif
#include "vhost.h"
#include "hw/hw.h"
/* For range_get_last */
diff --git a/hw/vhost_net.c b/hw/vhost_net.c
index 606aa0c..f4bddd4 100644
--- a/hw/vhost_net.c
+++ b/hw/vhost_net.c
@@ -20,7 +20,9 @@
#ifdef CONFIG_VHOST_NET
#include <linux/vhost.h>
+#ifdef CONFIG_EVENTFD
#include <sys/eventfd.h>
+#endif
#include <sys/socket.h>
#include <linux/kvm.h>
#include <fcntl.h>
--
1.5.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Use existing config check when including eventfd.h
2010-07-21 23:45 [Qemu-devel] [PATCH] Use existing config check when including eventfd.h Mike McCormack
@ 2010-07-22 8:11 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2010-07-22 8:11 UTC (permalink / raw)
To: Mike McCormack; +Cc: qemu-devel
On Thu, Jul 22, 2010 at 12:45 AM, Mike McCormack <mikem@ring3k.org> wrote:
> Signed-off-by: Mike McCormack <mikem@ring3k.org>
> ---
> hw/vhost.c | 2 ++
> hw/vhost_net.c | 2 ++
> 2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/hw/vhost.c b/hw/vhost.c
> index d37a66e..e1cd4d2 100644
> --- a/hw/vhost.c
> +++ b/hw/vhost.c
> @@ -11,7 +11,9 @@
> */
>
> #include <sys/ioctl.h>
> +#ifdef CONFIG_EVENTFD
> #include <sys/eventfd.h>
> +#endif
> #include "vhost.h"
> #include "hw/hw.h"
> /* For range_get_last */
> diff --git a/hw/vhost_net.c b/hw/vhost_net.c
> index 606aa0c..f4bddd4 100644
> --- a/hw/vhost_net.c
> +++ b/hw/vhost_net.c
> @@ -20,7 +20,9 @@
>
> #ifdef CONFIG_VHOST_NET
> #include <linux/vhost.h>
> +#ifdef CONFIG_EVENTFD
> #include <sys/eventfd.h>
> +#endif
> #include <sys/socket.h>
> #include <linux/kvm.h>
> #include <fcntl.h>
> --
vhost.c and vhost_net.c do not use sys/eventfd.h, please remove the
#include instead of #ifdefing it. The only source file that needs to
include it is event_notifier.c from what I can tell.
Stefan
> 1.5.6.5
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-22 8:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-21 23:45 [Qemu-devel] [PATCH] Use existing config check when including eventfd.h Mike McCormack
2010-07-22 8:11 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).