From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34096 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObyUZ-0003dM-Uw for qemu-devel@nongnu.org; Thu, 22 Jul 2010 12:19:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObyUS-0006Rx-HJ for qemu-devel@nongnu.org; Thu, 22 Jul 2010 12:19:24 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:62357) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObyUS-0006Rc-9T for qemu-devel@nongnu.org; Thu, 22 Jul 2010 12:19:20 -0400 Message-ID: <4C486F66.7000303@mail.berlios.de> Date: Thu, 22 Jul 2010 18:18:46 +0200 From: Stefan Weil MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/3] Fix broken if statements References: <1279742717-10804-1-git-send-email-jschopp@austin.ibm.com> In-Reply-To: <1279742717-10804-1-git-send-email-jschopp@austin.ibm.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joel Schopp Cc: qemu-devel@nongnu.org Am 21.07.2010 22:05, schrieb Joel Schopp: > I have decided to apply the broken window theory of crime > http://en.wikipedia.org/wiki/Broken_windows_theory to code, and > more specifically to qemu. I'm hoping that fixing seemingly trivial > bugs will actually fix some more serious bugs, make the code run > just a bit smoother, or at the very least leave us with easier to > maintain code. > > Joel Schopp (3): > remove dead code from hw/loader.c > fix variable type in qemu-io.c > remove pointless if from vl.c > > hw/loader.c | 5 ----- > qemu-io.c | 4 ++-- > vl.c | 4 +--- > 3 files changed, 3 insertions(+), 10 deletions(-) How did you apply the broken window theory of crime to software code? Is this still a secret, or can you tell us more? Regards Stefan Weil