From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: default to 0 minimal / optiomal I/O size
Date: Fri, 23 Jul 2010 12:50:12 +0200 [thread overview]
Message-ID: <4C4973E4.5030502@redhat.com> (raw)
In-Reply-To: <20100723073504.GA28166@lst.de>
Am 23.07.2010 09:35, schrieb Christoph Hellwig:
> Currently we set them to 512 bytes unless manually specified. Unforuntaly
> some brain-dead partitioning tools create unaligned partitions if they
> get low enough optiomal I/O size values, so don't report any at all
> unless explicitly set.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: qemu/block_int.h
> ===================================================================
> --- qemu.orig/block_int.h 2010-07-23 09:26:07.660494681 +0200
> +++ qemu/block_int.h 2010-07-23 09:26:20.323494685 +0200
> @@ -243,7 +243,7 @@ static inline unsigned int get_physical_
> _conf.logical_block_size, 512), \
> DEFINE_PROP_UINT16("physical_block_size", _state, \
> _conf.physical_block_size, 512), \
> - DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 512), \
> - DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 512)
> + DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0), \
> + DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 0)
>
> #endif /* BLOCK_INT_H */
This isn't reverting to the state before we reported anything, but it
reports values of 0 now. Is this defined for both virtio-blk and SCSI to
mean the same as no report at all? Or should we rather not advertise
VIRTIO_BLK_F_TOPOLOGY (and the SCSI equivalent) in this case?
Kevin
next prev parent reply other threads:[~2010-07-23 10:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 7:35 [Qemu-devel] [PATCH] block: default to 0 minimal / optiomal I/O size Christoph Hellwig
2010-07-23 10:50 ` Kevin Wolf [this message]
2010-07-23 11:30 ` Christoph Hellwig
2010-07-23 11:56 ` Kevin Wolf
2010-07-23 12:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4973E4.5030502@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).