From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: default to 0 minimal / optiomal I/O size
Date: Fri, 23 Jul 2010 13:56:50 +0200 [thread overview]
Message-ID: <4C498382.2020904@redhat.com> (raw)
In-Reply-To: <20100723113046.GA8898@lst.de>
Am 23.07.2010 13:30, schrieb Christoph Hellwig:
> On Fri, Jul 23, 2010 at 12:50:12PM +0200, Kevin Wolf wrote:
>> This isn't reverting to the state before we reported anything, but it
>> reports values of 0 now. Is this defined for both virtio-blk and SCSI to
>> mean the same as no report at all? Or should we rather not advertise
>> VIRTIO_BLK_F_TOPOLOGY (and the SCSI equivalent) in this case?
>
> For scsi it's explicitly defined that way, and there is not equivalent
> to the VIRTIO_BLK_F_TOPOLOGY because it will just use the VPD data if
> the page is long enough. virtio is a bit underspecified, but the
> Linux guest driver has the same behaviour as scsi in that respect.
Ok, then the right fix is to clarify the spec probably.
I've applied the patch to the block branch. This is something for 0.13,
too, I suppose?
Kevin
next prev parent reply other threads:[~2010-07-23 11:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 7:35 [Qemu-devel] [PATCH] block: default to 0 minimal / optiomal I/O size Christoph Hellwig
2010-07-23 10:50 ` Kevin Wolf
2010-07-23 11:30 ` Christoph Hellwig
2010-07-23 11:56 ` Kevin Wolf [this message]
2010-07-23 12:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C498382.2020904@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).