From: Kevin Wolf <kwolf@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Fix -snapshot deleting images on disk change
Date: Mon, 26 Jul 2010 11:03:56 +0200 [thread overview]
Message-ID: <4C4D4F7C.2040306@redhat.com> (raw)
In-Reply-To: <AANLkTimFu_z+HLRw+O2KM9EwJVS7U1DC1Adt4UKZxRjs@mail.gmail.com>
Am 25.07.2010 22:49, schrieb Blue Swirl:
> Block device change command did not copy BDRV_O_SNAPSHOT flag. Thus
> the new image did not have this flag and the file got deleted during
> opening.
>
> Fix by copying BDRV_O_SNAPSHOT flag.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Thanks, applied to the block branch.
> diff --git a/block.h b/block.h
> index c2a7e4c..db131a3 100644
> --- a/block.h
> +++ b/block.h
> @@ -202,6 +202,7 @@ const char
> *bdrv_get_encrypted_filename(BlockDriverState *bs);
Please avoid wrapped lines when you send patches, e.g. by using git
send-email.
Kevin
prev parent reply other threads:[~2010-07-26 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-25 20:49 [Qemu-devel] [PATCH] Fix -snapshot deleting images on disk change Blue Swirl
2010-07-26 6:58 ` Markus Armbruster
2010-07-26 9:03 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4D4F7C.2040306@redhat.com \
--to=kwolf@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).