From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46625 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OdTao-0005qw-A7 for qemu-devel@nongnu.org; Mon, 26 Jul 2010 15:44:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OdTan-0007uy-4v for qemu-devel@nongnu.org; Mon, 26 Jul 2010 15:44:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62448) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdTam-0007ue-UF for qemu-devel@nongnu.org; Mon, 26 Jul 2010 15:44:05 -0400 Message-ID: <4C4DE57E.2080406@redhat.com> Date: Mon, 26 Jul 2010 22:43:58 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help References: <4C4704FC020000480009AB6E@sinclair.provo.novell.com> <4C475EC0.2000805@codemonkey.ws> <20100721213238.GB28871@redhat.com> <4C476A8A.6000707@codemonkey.ws> <20100721215833.GC28871@redhat.com> <4C478534.2020106@codemonkey.ws> <20100722084225.GA1524@redhat.com> <4C485383.8020904@codemonkey.ws> <4C4DAF94.1040300@codemonkey.ws> <4C4DB74F.7090507@redhat.com> <4C4DBA71.1000808@codemonkey.ws> <4C4DBDCC.8090408@redhat.com> <4C4DDB25.90000@codemonkey.ws> <4C4DDFDC.3000608@redhat.com> <4C4DE38E.4050900@codemonkey.ws> In-Reply-To: <4C4DE38E.4050900@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Markus Armbruster , Bruce Rogers On 07/26/2010 10:35 PM, Anthony Liguori wrote: > >> >>>> If you want libvirt to do the right thing, provide a proper >>>> capabilities interface. Using the version has its downsides as >>>> much as the help text. >>> >>> That's simply not the case. Please, provide an actual example where >>> version is not reliable and backports aren't trivially easy to detect. >> >> >> t=0 starting point, cache=unsafe is unknown >> t=1 qemu upstream adds cache=unknown >> t=2 libvirt adds support for cache=unsafe, releases >> t=3 evil distro backports cache=unsafe, releases qemu-kvm-1.2.3.4 >> t=4 user tries libvirt from t=2 with qemu from t=3, cache=unsafe not >> detected >> >> version numbers force a libvirt update every time a feature is >> backported. > > That's a bogus scenario because said evil distro would also enhance > libvirt to detect the feature properly. That means a new libvirt release is needed. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.