From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50716 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OdTia-0002Y4-1D
	for qemu-devel@nongnu.org; Mon, 26 Jul 2010 15:52:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OdTiY-0000Qj-Ra
	for qemu-devel@nongnu.org; Mon, 26 Jul 2010 15:52:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2180)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OdTiY-0000Qc-Gj
	for qemu-devel@nongnu.org; Mon, 26 Jul 2010 15:52:06 -0400
Message-ID: <4C4DE75E.50507@redhat.com>
Date: Mon, 26 Jul 2010 22:51:58 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device
References: <1276633426-30995-1-git-send-email-cam@cs.ualberta.ca>	<4C4D922C.3020608@codemonkey.ws>
	<AANLkTi=fGngVkktjrULceOGqXr_goWtLt5AD=oagjm_3@mail.gmail.com>
In-Reply-To: <AANLkTi=fGngVkktjrULceOGqXr_goWtLt5AD=oagjm_3@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cam Macdonell <cam@cs.ualberta.ca>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

  On 07/26/2010 10:01 PM, Cam Macdonell wrote:
>
>> Is this against qemu.git or qemu-kvm.git?  It depends on functions like
>> qemu_ram_map() which are not present in qemu.git (and are present in
>> qemu-kvm.git).
> It is against qemu-kvm.git.  Is qemu_ram_map() going into qemu.git?
> Another function I use (and virtio in qemu-kvm uses as well) is
> kvm_set_irqfd() that is not qemu.git either.  Do I need ifdef these
> functions with CONFIG_KVM?
>
> Please advise as to how to handle these two functions and then I can
> rebase against qemu.git.

Please add qemu_ram_map() as a separate patch to avoid 
interdependencies.  Try to keep it at the same place etc., that will 
reduce merge difficulties later.

wrt kvm_set_irqfd(), its usage is optional, yes?  if so I recommend just 
dropping support for it temporarily.  I'll work at upstreaming 
kvm_set_irqfd() so you can re-add this functionality.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.