From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56783 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OdTw0-0001Fl-EK
	for qemu-devel@nongnu.org; Mon, 26 Jul 2010 16:06:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OdTvz-00029i-6f
	for qemu-devel@nongnu.org; Mon, 26 Jul 2010 16:06:00 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:57630)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OdTvz-00029b-3M
	for qemu-devel@nongnu.org; Mon, 26 Jul 2010 16:05:59 -0400
Received: by yxn35 with SMTP id 35so233050yxn.4
	for <qemu-devel@nongnu.org>; Mon, 26 Jul 2010 13:05:58 -0700 (PDT)
Message-ID: <4C4DEAA3.8090000@codemonkey.ws>
Date: Mon, 26 Jul 2010 15:05:55 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device
References: <1276633426-30995-1-git-send-email-cam@cs.ualberta.ca>	<4C4D922C.3020608@codemonkey.ws>
	<AANLkTi=fGngVkktjrULceOGqXr_goWtLt5AD=oagjm_3@mail.gmail.com>
	<4C4DE75E.50507@redhat.com>
In-Reply-To: <4C4DE75E.50507@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Cam Macdonell <cam@cs.ualberta.ca>, qemu-devel@nongnu.org, kvm@vger.kernel.org

On 07/26/2010 02:51 PM, Avi Kivity wrote:
>  On 07/26/2010 10:01 PM, Cam Macdonell wrote:
>>
>>> Is this against qemu.git or qemu-kvm.git?  It depends on functions like
>>> qemu_ram_map() which are not present in qemu.git (and are present in
>>> qemu-kvm.git).
>> It is against qemu-kvm.git.  Is qemu_ram_map() going into qemu.git?
>> Another function I use (and virtio in qemu-kvm uses as well) is
>> kvm_set_irqfd() that is not qemu.git either.  Do I need ifdef these
>> functions with CONFIG_KVM?
>>
>> Please advise as to how to handle these two functions and then I can
>> rebase against qemu.git.
>
> Please add qemu_ram_map() as a separate patch to avoid 
> interdependencies.  Try to keep it at the same place etc., that will 
> reduce merge difficulties later.

Oh, qemu_ram_map() has a horrible name.  It should be 
qemu_ram_alloc_from_ptr().  Otherwise, I agree with Avi.

Regards,

Anthony Liguori

> wrt kvm_set_irqfd(), its usage is optional, yes?  if so I recommend 
> just dropping support for it temporarily.  I'll work at upstreaming 
> kvm_set_irqfd() so you can re-add this functionality.
>