From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52240 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OdglN-0007Qo-Iy
	for qemu-devel@nongnu.org; Tue, 27 Jul 2010 05:47:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OdglI-00062Z-DT
	for qemu-devel@nongnu.org; Tue, 27 Jul 2010 05:47:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1026)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OdglI-00062K-5Y
	for qemu-devel@nongnu.org; Tue, 27 Jul 2010 05:47:48 -0400
Message-ID: <4C4EAB3E.6090306@redhat.com>
Date: Tue, 27 Jul 2010 11:47:42 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help
References: <4C4704FC020000480009AB6E@sinclair.provo.novell.com>	<4C475EC0.2000805@codemonkey.ws>
	<20100721213238.GB28871@redhat.com>	<4C476A8A.6000707@codemonkey.ws>
	<20100721215833.GC28871@redhat.com>	<4C478534.2020106@codemonkey.ws>
	<20100722084225.GA1524@redhat.com>	<4C485383.8020904@codemonkey.ws>	<m3vd86ocfh.fsf@blackfin.pond.sub.org>	<4C4DAF94.1040300@codemonkey.ws>
	<4C4DB74F.7090507@redhat.com>	<4C4DBA71.1000808@codemonkey.ws>
	<4C4DBDCC.8090408@redhat.com>	<4C4DDB25.90000@codemonkey.ws>
	<4C4DDFDC.3000608@redhat.com>	<4C4DE38E.4050900@codemonkey.ws>
	<m339v5pcmv.fsf@blackfin.pond.sub.org>
In-Reply-To: <m339v5pcmv.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Bruce Rogers <brogers@novell.com>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

On 07/27/10 10:11, Markus Armbruster wrote:
> Anthony Liguori <anthony@codemonkey.ws> writes:
>> On 07/26/2010 02:19 PM, Avi Kivity wrote:
>>> We should try to support all users, prioritized by the number of end
>>> users they represent.  If this patch broke some other large user
>>> we'd be in a bind.  But likely this isn't the case so we aren't.
>>
>> As I've said, I'm pragmatic and that's why I've argued for these
>> changes in the past.  But libvirt should have changed a long time ago
>> to using something more reliable (like version).
> 
> You want pragmatic?  I can give you pragmatic!  We apply the trivial
> patch that helps libvirt and hurts nobody, and save our breath & typing
> for designing and implementing a capability system.

To be honest, this is exactly the same problem we had when the output
from -version changed and libvirt broke because it did static string
parsing instead of doing it properly. Back then the output of -version
was changed back to accommodate libvirt, but I am not aware that libvirt
went ahead and fixed the real problem in the mean time.

While I don't see this specific change being problematic, I don't like
the trend of hacking things to accommodate a specific library or
application, when the group relying on the feature really should start
providing the code for the real solution.

Just my $0.02

Jes