From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59296 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OdjcK-00027z-6U for qemu-devel@nongnu.org; Tue, 27 Jul 2010 08:50:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OdjcH-0005xs-Hu for qemu-devel@nongnu.org; Tue, 27 Jul 2010 08:50:43 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:47219) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdjcH-0005xf-E4 for qemu-devel@nongnu.org; Tue, 27 Jul 2010 08:50:41 -0400 Received: by gwb11 with SMTP id 11so507796gwb.4 for ; Tue, 27 Jul 2010 05:50:40 -0700 (PDT) Message-ID: <4C4ED617.1030100@codemonkey.ws> Date: Tue, 27 Jul 2010 07:50:31 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help References: <4C4704FC020000480009AB6E@sinclair.provo.novell.com> <4C475EC0.2000805@codemonkey.ws> <20100721213238.GB28871@redhat.com> <4C476A8A.6000707@codemonkey.ws> <20100721215833.GC28871@redhat.com> <4C478534.2020106@codemonkey.ws> <20100722084225.GA1524@redhat.com> <4C485383.8020904@codemonkey.ws> <4C4DAF94.1040300@codemonkey.ws> <4C4DB74F.7090507@redhat.com> <4C4DBA71.1000808@codemonkey.ws> <4C4DBDCC.8090408@redhat.com> <4C4DDB25.90000@codemonkey.ws> <4C4DDFDC.3000608@redhat.com> <4C4DE38E.4050900@codemonkey.ws> <4C4EAB3E.6090306@redhat.com> <4C4ED164.8010107@redhat.com> In-Reply-To: <4C4ED164.8010107@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson Cc: Jes Sorensen , Bruce Rogers , qemu-devel@nongnu.org, Markus Armbruster , Avi Kivity On 07/27/2010 07:30 AM, Cole Robinson wrote: > On 07/27/2010 05:47 AM, Jes Sorensen wrote: > >> On 07/27/10 10:11, Markus Armbruster wrote: >> >>> Anthony Liguori writes: >>> >>>> On 07/26/2010 02:19 PM, Avi Kivity wrote: >>>> >>>>> We should try to support all users, prioritized by the number of end >>>>> users they represent. If this patch broke some other large user >>>>> we'd be in a bind. But likely this isn't the case so we aren't. >>>>> >>>> As I've said, I'm pragmatic and that's why I've argued for these >>>> changes in the past. But libvirt should have changed a long time ago >>>> to using something more reliable (like version). >>>> >>> You want pragmatic? I can give you pragmatic! We apply the trivial >>> patch that helps libvirt and hurts nobody, and save our breath& typing >>> for designing and implementing a capability system. >>> >> To be honest, this is exactly the same problem we had when the output >> from -version changed and libvirt broke because it did static string >> parsing instead of doing it properly. Back then the output of -version >> was changed back to accommodate libvirt, but I am not aware that libvirt >> went ahead and fixed the real problem in the mean time. >> >> > The output of -version was not changed back, the revert was rejected. > (Meaning QEMU has no stable interface for determining version info. > Actually, we do. 'info version' in the monitor returns just the version. Additionally, -version on the command line spits out just a single version string. The trouble libvirt has is that it's parsing the help output and needs to use a string to identify which line is the version (due to the way it's parsing the output). Notice a theme here? Regards, Anthony Liguori