From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60823 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OdqJi-0005FD-8o
	for qemu-devel@nongnu.org; Tue, 27 Jul 2010 15:59:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1OdqJh-0002F3-A7
	for qemu-devel@nongnu.org; Tue, 27 Jul 2010 15:59:58 -0400
Received: from b.mail.sonic.net ([64.142.19.5]:32978)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1OdqJh-0002ET-1Y
	for qemu-devel@nongnu.org; Tue, 27 Jul 2010 15:59:57 -0400
Message-ID: <4C4F3AB3.5050900@twiddle.net>
Date: Tue, 27 Jul 2010 12:59:47 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 07/12] linux-user: Load symbols from the
	interpreter.
References: <1280251538-6860-1-git-send-email-rth@twiddle.net>
	<1280251538-6860-8-git-send-email-rth@twiddle.net>
	<alpine.LNX.2.00.1007272244220.6426@linmac>
In-Reply-To: <alpine.LNX.2.00.1007272244220.6426@linmac>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org

On 07/27/2010 11:45 AM, malc wrote:
>> +    syms = realloc(syms, nsyms * sizeof(*syms));
> 
> Realloc can fail here.

I don't believe it can.  This (pre-existing) statement *reduces*
the existing allocation of syms.  I'd be surprised if any malloc
implementation fails on a size reduction.

That said, I'd be happy enough to eliminate the call entirely.


r~