From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34710 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oe3se-0004Zs-7w for qemu-devel@nongnu.org; Wed, 28 Jul 2010 06:29:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oe3sd-00023T-0Z for qemu-devel@nongnu.org; Wed, 28 Jul 2010 06:28:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47762) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oe3sc-000237-Q8 for qemu-devel@nongnu.org; Wed, 28 Jul 2010 06:28:54 -0400 Message-ID: <4C500682.1090106@redhat.com> Date: Wed, 28 Jul 2010 13:29:22 +0300 From: Michael Goldish MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC PATCH 02/14] KVM Test: Add a function get_interface_name() to kvm_net_utils.py References: <20100720013414.2212.13476.stgit@z> <20100720013506.2212.7371.stgit@z> <1280196535.4009.126.camel@freedom> In-Reply-To: <1280196535.4009.126.camel@freedom> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lucas Meneghel Rodrigues Cc: autotest@test.kernel.org, Amos Kong , qemu-devel@nongnu.org, kvm@vger.kernel.org On 07/27/2010 05:08 AM, Lucas Meneghel Rodrigues wrote: > On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: >> The function get_interface_name is used to get the interface name of linux >> guest through the macaddress of specified macaddress. > > I wonder if it wouldn't be overkill to have separate utility libraries > on the kvm test instead of a single kvm_utils and kvm_test_utils like > you are proposing. Any thoughts Michael? Yes, looks like this could be in kvm_test_utils.py, especially if there's only a small number of functions here. >> Signed-off-by: Jason Wang >> Signed-off-by: Amos Kong >> --- >> 0 files changed, 0 insertions(+), 0 deletions(-) >> >> diff --git a/client/tests/kvm/kvm_net_utils.py b/client/tests/kvm/kvm_net_utils.py >> new file mode 100644 >> index 0000000..ede4965 >> --- /dev/null >> +++ b/client/tests/kvm/kvm_net_utils.py >> @@ -0,0 +1,18 @@ >> +import re >> + >> +def get_linux_ifname(session, mac_address): >> + """ >> + Get the interface name through the mac address. >> + >> + @param session: session to the virtual machine >> + @mac_address: the macaddress of nic >> + """ >> + >> + output = session.get_command_output("ifconfig -a") >> + >> + try: >> + ethname = re.findall("(\w+)\s+Link.*%s" % mac_address, output, >> + re.IGNORECASE)[0] >> + return ethname >> + except: >> + return None >> >> > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html