From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42076 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Oe4Eu-0001cN-VQ
	for qemu-devel@nongnu.org; Wed, 28 Jul 2010 06:51:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1Oe4Eu-0005tX-2K
	for qemu-devel@nongnu.org; Wed, 28 Jul 2010 06:51:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2790)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1Oe4Et-0005tO-QZ
	for qemu-devel@nongnu.org; Wed, 28 Jul 2010 06:51:56 -0400
Message-ID: <4C500BC6.6020900@redhat.com>
Date: Wed, 28 Jul 2010 13:51:50 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Use kvm32/kvm64 as default CPUs when running
	under KVM.
References: <1280311527-2650-1-git-send-email-Jes.Sorensen@redhat.com>
In-Reply-To: <1280311527-2650-1-git-send-email-Jes.Sorensen@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

  On 07/28/2010 01:05 PM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> KVM has a minimum CPU requirement in order to run, so there is no
> reason to default to the very basic family 6, model 2 (or model 3 for
> qemu32) CPU since the additional features are going to be available on
> the host CPU.
>
>
> @@ -866,11 +867,19 @@ void pc_cpus_init(const char *cpu_model)
>
>       /* init CPUs */
>       if (cpu_model == NULL) {
> +        if (kvm_enabled()) {
>   #ifdef TARGET_X86_64
> -        cpu_model = "qemu64";
> +            cpu_model = "kvm64";
>   #else
> -        cpu_model = "qemu32";
> +            cpu_model = "kvm32";
>   #endif
> +        } else {
> +#ifdef TARGET_X86_64
> +            cpu_model = "qemu64";
> +#else
> +            cpu_model = "qemu32";
> +#endif
> +        }
>       }

What about -M 0.12?  It needs to retain the old values.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.