From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51401 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OeGXs-0001T1-GW
	for qemu-devel@nongnu.org; Wed, 28 Jul 2010 20:00:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1OeGXr-0004Xm-Cx
	for qemu-devel@nongnu.org; Wed, 28 Jul 2010 20:00:20 -0400
Received: from a.mail.sonic.net ([64.142.16.245]:53157)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1OeGXr-0004Xd-6P
	for qemu-devel@nongnu.org; Wed, 28 Jul 2010 20:00:19 -0400
Message-ID: <4C50BAAF.3030505@twiddle.net>
Date: Wed, 28 Jul 2010 16:18:07 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 11/12] linux-user: Extract load_elf_image
	from load_elf_interp.
References: <1280251538-6860-1-git-send-email-rth@twiddle.net>
	<1280251538-6860-12-git-send-email-rth@twiddle.net>
	<20100728220017.GA14422@laped.lan>
In-Reply-To: <20100728220017.GA14422@laped.lan>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: qemu-devel@nongnu.org

On 07/28/2010 03:00 PM, Edgar E. Iglesias wrote:
>> -    NEW_AUX_ENT(AT_BASE, (abi_ulong)(interp_load_addr));
>> +    NEW_AUX_ENT(AT_BASE, (abi_ulong)(interp_info->load_addr));
> 
> 
> Hi Richard,
> 
> I think this part breaks loading of statically linked ELFs (no
> interpreter). I beleive Linux sets AT_BASE to zero in those cases.

You're right.  This should be 

  interp_info ? interp_info->load_addr : 0


r~