From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59847 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OfDaW-0005WC-Hq for qemu-devel@nongnu.org; Sat, 31 Jul 2010 11:03:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OfDaU-0004hh-Fo for qemu-devel@nongnu.org; Sat, 31 Jul 2010 11:03:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1850) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OfDaU-0004hZ-7M for qemu-devel@nongnu.org; Sat, 31 Jul 2010 11:02:58 -0400 Message-ID: <4C5435C5.2040402@redhat.com> Date: Sat, 31 Jul 2010 16:40:05 +0200 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode References: <1279900598-8432-1-git-send-email-Jes.Sorensen@redhat.com> <20100730210847.GD20459@volta.aurel32.net> <4C53E9FD.4070109@redhat.com> <20100731141944.GC31640@hall.aurel32.net> In-Reply-To: <20100731141944.GC31640@hall.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: Alex.Williamson@redhat.com, qemu-devel@nongnu.org On 07/31/10 16:19, Aurelien Jarno wrote: > On Sat, Jul 31, 2010 at 11:16:45AM +0200, Jes Sorensen wrote: >> On 07/30/10 23:08, Aurelien Jarno wrote: >>> Missing braces around the return 0 line. >> >> Half the QEMU code base doesn't have braces around single line if >> statements, including in hw/pci.c. Adding braces here would be inconsistent. >> > > If we follow the coding style in new patches, it will eventually become > consistent. > If you want that, please do it in a separate patch for the entire file, otherwise it will never become consistent. However it doesn't change the issue either that putting braces around a single line like this is bad coding style. Jes