From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Alex.Williamson@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode
Date: Sat, 31 Jul 2010 17:21:34 +0200 [thread overview]
Message-ID: <4C543F7E.5020300@redhat.com> (raw)
In-Reply-To: <20100731151318.GF31640@hall.aurel32.net>
On 07/31/10 17:13, Aurelien Jarno wrote:
> On Sat, Jul 31, 2010 at 04:40:05PM +0200, Jes Sorensen wrote:
>> If you want that, please do it in a separate patch for the entire file,
>> otherwise it will never become consistent. However it doesn't change the
>> issue either that putting braces around a single line like this is bad
>> coding style.
>
> We got this discussions numerous times, and I am not going to start it
> again. If you want to see the patch applied, just follow the rules.
>
Then I would like to know why you do not apply this silly rule to every
patch submitted. There's patches going in almost every day that doesn't
use this hopeless formatting.
Jes
next prev parent reply other threads:[~2010-07-31 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 15:56 [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode Jes.Sorensen
2010-07-30 21:08 ` Aurelien Jarno
2010-07-31 9:16 ` Jes Sorensen
2010-07-31 14:19 ` Aurelien Jarno
2010-07-31 14:40 ` Jes Sorensen
2010-07-31 15:13 ` Aurelien Jarno
2010-07-31 15:21 ` Jes Sorensen [this message]
2010-07-31 15:29 ` Aurelien Jarno
-- strict thread matches above, loose matches on Subject: below --
2010-07-23 12:17 Jes.Sorensen
2010-07-23 15:37 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C543F7E.5020300@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Alex.Williamson@redhat.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).