Re: [Qemu-devel] [PATCH] Add new user mode option -ignore-environment

[Stefan Weil <weil@mail.berlios.de>]

Am 16.07.2010 15:09, schrieb Stefan Weil:
> Am 16.07.2010 09:04, schrieb Markus Armbruster:
>> Stefan Weil<weil@mail.berlios.de>  writes:
>>
>>> An empty environment is sometimes useful in user mode.
>>> The new option provides it for linux-user and bsd-user
>>> (darwin-user still has no environment related options).
>> Stupid question: why is /usr/bin/env insufficient?
>>
>> [...]
>>
>
> In most cases it is sufficient (but not always available - Windows...).
> The options -U and -E are also redundant and can be replaced by
> /usr/bin/env.
>
> But -U and -E exist, so completing the set of environment related
> options seems to be logical. The name of the new option was
> inspired by /usr/bin/env!
>
> And finally, there is a use case where /usr/bin/env is a bad choice:
> just look for "getenv" and you will find one in linux-user/main.c.
> Removing the environment via /usr/bin/env will also remove
> environment variables which are read by qemu's runtime code.


Is there any more feedback on this patch?
Or can it be commited to git master?