From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48668 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OfbSM-0001YH-Bn
	for qemu-devel@nongnu.org; Sun, 01 Aug 2010 12:32:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1OfX1z-0007va-JB
	for qemu-devel@nongnu.org; Sun, 01 Aug 2010 07:48:40 -0400
Received: from moutng.kundenserver.de ([212.227.17.8]:51067)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1OfX1z-0007v5-3j
	for qemu-devel@nongnu.org; Sun, 01 Aug 2010 07:48:39 -0400
Message-ID: <4C555F08.9060103@mail.berlios.de>
Date: Sun, 01 Aug 2010 13:48:24 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Add new user mode option -ignore-environment
References: <1279225717-7309-1-git-send-email-weil@mail.berlios.de>	<m37hkv52n1.fsf@blackfin.pond.sub.org>
	<4C405A1E.6090003@mail.berlios.de>
In-Reply-To: <4C405A1E.6090003@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Markus Armbruster <armbru@redhat.com>

Am 16.07.2010 15:09, schrieb Stefan Weil:
> Am 16.07.2010 09:04, schrieb Markus Armbruster:
>> Stefan Weil<weil@mail.berlios.de>  writes:
>>
>>> An empty environment is sometimes useful in user mode.
>>> The new option provides it for linux-user and bsd-user
>>> (darwin-user still has no environment related options).
>> Stupid question: why is /usr/bin/env insufficient?
>>
>> [...]
>>
>
> In most cases it is sufficient (but not always available - Windows...).
> The options -U and -E are also redundant and can be replaced by
> /usr/bin/env.
>
> But -U and -E exist, so completing the set of environment related
> options seems to be logical. The name of the new option was
> inspired by /usr/bin/env!
>
> And finally, there is a use case where /usr/bin/env is a bad choice:
> just look for "getenv" and you will find one in linux-user/main.c.
> Removing the environment via /usr/bin/env will also remove
> environment variables which are read by qemu's runtime code.


Is there any more feedback on this patch?
Or can it be commited to git master?