From: Anthony Liguori <anthony@codemonkey.ws>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] Drop braces around single statement rule
Date: Mon, 02 Aug 2010 11:32:05 -0500 [thread overview]
Message-ID: <4C56F305.3010303@codemonkey.ws> (raw)
In-Reply-To: <AANLkTin3vwijKWVm0Cs9q5Q3bL2orAzaw0vwa+_9Abnu@mail.gmail.com>
On 08/02/2010 11:29 AM, Blue Swirl wrote:
>> Yeah, I'm neglecting the fact that we're not consistent as maintainers and
>> I'm all for dropping it from CODING_STYLE.
>>
> I'd rather expand the document. For example, I like the approach libvirt takes:
> http://libvirt.org/git/?p=libvirt.git;a=blob_plain;f=HACKING;hb=HEAD
>
> Not specifically to braces, but they describe types and memory
> allocation etc. which is FAQ stuff for us too.
>
I agree 100%. There are a lot of idioms in QEMU that would be good to
document for people learning the code base.
But I think that's orthogonal to the discussion of whether we want to
keep the if rule and whether we want to enforce all of coding style at
commit time.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2010-08-02 16:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-31 16:23 [Qemu-devel] [PATCH] Drop braces around single statement rule malc
2010-07-31 16:47 ` Aurelien Jarno
2010-07-31 16:51 ` Aurelien Jarno
2010-07-31 20:23 ` Blue Swirl
2010-07-31 20:35 ` malc
2010-07-31 23:49 ` Aurelien Jarno
2010-08-02 15:20 ` Anthony Liguori
2010-08-02 15:41 ` Kevin Wolf
2010-08-02 15:48 ` Anthony Liguori
2010-08-02 16:06 ` malc
2010-08-02 16:18 ` Anthony Liguori
2010-08-02 16:29 ` Blue Swirl
2010-08-02 16:32 ` Anthony Liguori [this message]
2010-08-02 15:55 ` malc
2010-08-02 16:04 ` Anthony Liguori
2010-08-02 16:24 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C56F305.3010303@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).