From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48448 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ofxvz-0006ou-Li
	for qemu-devel@nongnu.org; Mon, 02 Aug 2010 12:32:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Ofxvy-0007D5-B9
	for qemu-devel@nongnu.org; Mon, 02 Aug 2010 12:32:15 -0400
Received: from mail-qw0-f45.google.com ([209.85.216.45]:32846)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Ofxvy-0007Ct-8X
	for qemu-devel@nongnu.org; Mon, 02 Aug 2010 12:32:14 -0400
Received: by qwi4 with SMTP id 4so1790586qwi.4
	for <qemu-devel@nongnu.org>; Mon, 02 Aug 2010 09:32:13 -0700 (PDT)
Message-ID: <4C56F305.3010303@codemonkey.ws>
Date: Mon, 02 Aug 2010 11:32:05 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Drop braces around single statement rule
References: <1280593414-2232-1-git-send-email-av1474@comtv.ru>
	<AANLkTi=Bs0eegcR2C3=dNd=VZ7Zz-a2N+hj-uBAXN+09@mail.gmail.com>
	<20100731234956.GJ31640@hall.aurel32.net>
	<4C56E253.7010403@codemonkey.ws> <4C56E732.7060102@redhat.com>
	<4C56E8CB.1090104@codemonkey.ws>
	<alpine.LNX.2.00.1008022005020.1676@linmac>
	<4C56EFD2.9010908@codemonkey.ws>
	<AANLkTin3vwijKWVm0Cs9q5Q3bL2orAzaw0vwa+_9Abnu@mail.gmail.com>
In-Reply-To: <AANLkTin3vwijKWVm0Cs9q5Q3bL2orAzaw0vwa+_9Abnu@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>

On 08/02/2010 11:29 AM, Blue Swirl wrote:
>> Yeah, I'm neglecting the fact that we're not consistent as maintainers and
>> I'm all for dropping it from CODING_STYLE.
>>      
> I'd rather expand the document. For example, I like the approach libvirt takes:
> http://libvirt.org/git/?p=libvirt.git;a=blob_plain;f=HACKING;hb=HEAD
>
> Not specifically to braces, but they describe types and memory
> allocation etc. which is FAQ stuff for us too.
>    

I agree 100%.  There are a lot of idioms in QEMU that would be good to 
document for people learning the code base.

But I think that's orthogonal to the discussion of whether we want to 
keep the if rule and whether we want to enforce all of coding style at 
commit time.

Regards,

Anthony Liguori