From: Anthony Liguori <anthony@codemonkey.ws>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv3] Load "bootsplash.jpg" if present
Date: Mon, 02 Aug 2010 11:52:22 -0500 [thread overview]
Message-ID: <4C56F7C6.8040204@codemonkey.ws> (raw)
In-Reply-To: <20100802164752.GA13438@morn.localdomain>
On 08/02/2010 11:47 AM, Kevin O'Connor wrote:
> On Mon, Aug 02, 2010 at 11:33:33AM -0500, Anthony Liguori wrote:
>
>> On 08/02/2010 11:11 AM, Kevin O'Connor wrote:
>>
>>> Load the "bootsplash.jpg" file into fw_cfg if it is found in the roms
>>> directory.
>>>
>> Sorry, I should have provided this in the first response.
>>
>> Does the bootsplash cause a delay in startup time? If so, we'll
>> want to be able to disable this at boot time via the -boot option.
>> If it doesn't, this patch is probably fine as is.
>>
> That's okay - the patch is intended to start discussion anyway.
>
> There is no added delay for the bootsplash. However, it does take
> time to decompress it. On my machine it can take between 200-300ms
> for the jpeg code.
>
> It may make more sense for SeaBIOS to only bother with the bootsplash
> if the boot menu is enabled (or some new option) - as otherwise the
> picture is basically cleared immiediately after it's shown.
>
Yeah, if there's no boot menu and no boot menu delay, I imagine the boot
splash ends up just being a blip on the screen, right?
We definitely want a "boot as fast as you possibly can" mode for the
BIOS although for non-developer environments, I think a boot splash is a
nice touch.
BTW, we need to document somewhere any assumptions SeaBIOS has about the
JPEG. I see that it expects a 1024x768 image. Any additional
restrictions on the jpeg image?
Regards,
Anthony Liguori
> -Kevin
>
next prev parent reply other threads:[~2010-08-02 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 16:11 [Qemu-devel] [PATCHv3] Load "bootsplash.jpg" if present Kevin O'Connor
2010-08-02 16:33 ` Anthony Liguori
2010-08-02 16:47 ` Kevin O'Connor
2010-08-02 16:52 ` Anthony Liguori [this message]
2010-08-02 18:10 ` Kevin O'Connor
2010-08-02 18:54 ` Anthony Liguori
2010-08-03 9:52 ` Richard W.M. Jones
2010-08-03 12:51 ` Anthony Liguori
2010-08-03 12:54 ` Richard W.M. Jones
2010-08-03 13:04 ` Richard W.M. Jones
2010-08-03 13:33 ` Anthony Liguori
2010-08-03 14:38 ` [Qemu-devel] " Paolo Bonzini
2010-08-04 1:07 ` Kevin O'Connor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C56F7C6.8040204@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).