From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] QEMUFileBuffered: indicate that we're ready when the underlying file is ready
Date: Tue, 03 Aug 2010 09:12:52 +0300 [thread overview]
Message-ID: <4C57B364.8090500@redhat.com> (raw)
In-Reply-To: <1278521062-13795-1-git-send-email-avi@redhat.com>
On 07/07/2010 07:44 PM, Avi Kivity wrote:
> QEMUFileBuffered stops writing when the underlying QEMUFile is not ready,
> and tells its producer so. However, when the underlying QEMUFile becomes
> ready, it neglects to pass that information along, resulting in stoppage
> of all data until the next tick (a tenths of a second).
>
> Usually this doesn't matter, because most QEMUFiles used with QEMUFileBuffered
> are almost always ready, but in the case of exec: migration this is not true,
> due to the small pipe buffers used to connect to the target process. The
> result is very slow migration.
>
> Fix by detecting the readiness notification and propagating it. The detection
> is a little ugly since QEMUFile overloads put_buffer() to send it, but that's
> the suject for a different patch.
Ping.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2010-08-03 6:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 16:44 [Qemu-devel] [PATCH] QEMUFileBuffered: indicate that we're ready when the underlying file is ready Avi Kivity
2010-08-03 6:12 ` Avi Kivity [this message]
2010-08-03 13:00 ` [Qemu-devel] " Luiz Capitulino
2010-08-19 13:12 ` Avi Kivity
2010-08-19 15:19 ` [Qemu-devel] " Anthony Liguori
2010-08-29 9:00 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C57B364.8090500@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).