From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38590 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OgGxi-0007oV-40
	for qemu-devel@nongnu.org; Tue, 03 Aug 2010 08:51:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OgGxg-0001V0-UX
	for qemu-devel@nongnu.org; Tue, 03 Aug 2010 08:51:17 -0400
Received: from mail-gw0-f45.google.com ([74.125.83.45]:44445)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OgGxg-0001Uu-SG
	for qemu-devel@nongnu.org; Tue, 03 Aug 2010 08:51:16 -0400
Received: by gwb11 with SMTP id 11so1772159gwb.4
	for <qemu-devel@nongnu.org>; Tue, 03 Aug 2010 05:51:16 -0700 (PDT)
Message-ID: <4C5810B6.3020702@codemonkey.ws>
Date: Tue, 03 Aug 2010 07:51:02 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCHv3] Load "bootsplash.jpg" if present
References: <20100802161157.GA11743@morn.localdomain>
	<4C56F35D.6020708@codemonkey.ws>
	<20100802164752.GA13438@morn.localdomain>
	<20100803095221.GB16372@amd.home.annexia.org>
In-Reply-To: <20100803095221.GB16372@amd.home.annexia.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: Kevin O'Connor <kevin@koconnor.net>, qemu-devel@nongnu.org

On 08/03/2010 04:52 AM, Richard W.M. Jones wrote:
> On Mon, Aug 02, 2010 at 12:47:53PM -0400, Kevin O'Connor wrote:
>    
>> On Mon, Aug 02, 2010 at 11:33:33AM -0500, Anthony Liguori wrote:
>>      
>>> On 08/02/2010 11:11 AM, Kevin O'Connor wrote:
>>>        
>>>> Load the "bootsplash.jpg" file into fw_cfg if it is found in the roms
>>>> directory.
>>>>          
>>> Sorry, I should have provided this in the first response.
>>>
>>> Does the bootsplash cause a delay in startup time?  If so, we'll
>>> want to be able to disable this at boot time via the -boot option.
>>> If it doesn't, this patch is probably fine as is.
>>>        
>> That's okay - the patch is intended to start discussion anyway.
>>
>> There is no added delay for the bootsplash.  However, it does take
>> time to decompress it.  On my machine it can take between 200-300ms
>> for the jpeg code.
>>      
> Does it detect a "headless" boot and disable itself completely?
>
> 300ms is 5% of libguestfs boot time ...
>    

If menu=off, it probably just shouldn't display.  I assume libguestfs is 
passing menu=off...

Regards,

Anthony Liguori

> Rich.
>
>