From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44537 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OgLfn-0002tp-CK
	for qemu-devel@nongnu.org; Tue, 03 Aug 2010 13:53:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OgLfm-00051I-4q
	for qemu-devel@nongnu.org; Tue, 03 Aug 2010 13:53:07 -0400
Received: from mail-qy0-f180.google.com ([209.85.216.180]:34029)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OgLfl-000517-Uj
	for qemu-devel@nongnu.org; Tue, 03 Aug 2010 13:53:06 -0400
Received: by qyk31 with SMTP id 31so1405084qyk.4
	for <qemu-devel@nongnu.org>; Tue, 03 Aug 2010 10:53:05 -0700 (PDT)
Message-ID: <4C58577C.90408@codemonkey.ws>
Date: Tue, 03 Aug 2010 12:53:00 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] RFC adding ioctl's to virtserial/virtconsole
References: <1998763220.603051280770128553.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
	<4C5703A1.2040500@codemonkey.ws> <4C57D768.20401@redhat.com>
	<4C5815BC.6030600@codemonkey.ws> <4C583594.8060903@redhat.com>
	<4C5839D0.1060109@codemonkey.ws> <4C5846DD.90209@redhat.com>
	<4C58479E.2000805@codemonkey.ws> <4C584B8D.6090405@redhat.com>
In-Reply-To: <4C584B8D.6090405@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, Anthony Liguori <aliguori@redhat.com>, Alon Levy <alevy@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 08/03/2010 12:02 PM, Gerd Hoffmann wrote:
> On 08/03/10 18:45, Anthony Liguori wrote:
>> On 08/03/2010 11:42 AM, Gerd Hoffmann wrote:
>>> spice-vmc code registers/unregisters the interface within the spice
>>> server. So the interface is only activated in case the guest uses it.
>>> Spice client sees the interface being active or not and can act
>>> accordingly.
>>
>> So we have to migrate connected state?
>
> virtio-serial handles that already.

And we have to propagate this upon load to the char device backend.

Do we assume that the chardev is in the CONNECTED state initially?  If 
we do a loadvm at run time while we're in the CONNECTED state, do we 
generate a DISCONNECTED followed by CONNECTED state transition?  If we 
loadvm to a state where we were in the DISCONNECTED state, does that 
generate DISCONNECTED followed by CONNECTED followed by DISCONNECTED or 
just DISCONNECTED?

This is exactly the type of problem that we've had in the past by not 
having an API that clearly forces management of life cycle.

Regards,

Anthony Liguori

>
> cheers,
>   Gerd
>