From: Kevin Wolf <kwolf@redhat.com>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: Aaron Mason <aaron.mason@thats-too-much.info>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Added an option to set the VMDK adapter type
Date: Wed, 04 Aug 2010 14:29:45 +0200 [thread overview]
Message-ID: <4C595D39.8040301@redhat.com> (raw)
In-Reply-To: <AANLkTi=Kyj76EZYUptAE+nBYy2XGo0+QfxvrkBwQ27X-@mail.gmail.com>
Am 04.08.2010 14:27, schrieb andrzej zaborowski:
> Hi,
>
> On 4 August 2010 12:30, Kevin Wolf <kwolf@redhat.com> wrote:
>> Am 04.08.2010 01:46, schrieb Aaron Mason:
>>> + const char *real_filename, *temp_str, *adapterType = "ide";
>
> Sorry to complain about style, but note that uppercase characters are
> not used in variable names in Qemu (that I see).
Whoops, missed that one when complaining about the other style problems.
Yes, this should be adapter_type.
Kevin
next prev parent reply other threads:[~2010-08-04 12:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 23:46 [Qemu-devel] [PATCH] Added an option to set the VMDK adapter type Aaron Mason
2010-08-04 7:16 ` Natalia Portillo
2010-08-04 10:30 ` Kevin Wolf
2010-08-04 12:27 ` andrzej zaborowski
2010-08-04 12:29 ` Kevin Wolf [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-08-04 21:07 Aaron Mason
[not found] <3621879199971178442@unknownmsgid>
2010-08-06 11:40 ` Aaron Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C595D39.8040301@redhat.com \
--to=kwolf@redhat.com \
--cc=aaron.mason@thats-too-much.info \
--cc=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).