From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50148 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ogd6P-00077C-Ng
	for qemu-devel@nongnu.org; Wed, 04 Aug 2010 08:29:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1Ogd6O-00049B-J2
	for qemu-devel@nongnu.org; Wed, 04 Aug 2010 08:29:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29951)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1Ogd6O-000493-A1
	for qemu-devel@nongnu.org; Wed, 04 Aug 2010 08:29:44 -0400
Message-ID: <4C595D39.8040301@redhat.com>
Date: Wed, 04 Aug 2010 14:29:45 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Added an option to set the VMDK adapter type
References: <AANLkTinLdLuTD02aAPezj=WgnDzm3yggg+1xz+=RxGb5@mail.gmail.com>	<4C59412C.3080707@redhat.com>
	<AANLkTi=Kyj76EZYUptAE+nBYy2XGo0+QfxvrkBwQ27X-@mail.gmail.com>
In-Reply-To: <AANLkTi=Kyj76EZYUptAE+nBYy2XGo0+QfxvrkBwQ27X-@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: Aaron Mason <aaron.mason@thats-too-much.info>, qemu-devel@nongnu.org

Am 04.08.2010 14:27, schrieb andrzej zaborowski:
> Hi,
> 
> On 4 August 2010 12:30, Kevin Wolf <kwolf@redhat.com> wrote:
>> Am 04.08.2010 01:46, schrieb Aaron Mason:
>>> +    const char *real_filename, *temp_str, *adapterType = "ide";
> 
> Sorry to complain about style, but note that uppercase characters are
> not used in variable names in Qemu (that I see).

Whoops, missed that one when complaining about the other style problems.
Yes, this should be adapter_type.

Kevin