From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52410 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OiOAM-0006fb-32
	for qemu-devel@nongnu.org; Mon, 09 Aug 2010 04:57:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <prerna@linux.vnet.ibm.com>) id 1OiOAK-00045z-Sr
	for qemu-devel@nongnu.org; Mon, 09 Aug 2010 04:57:05 -0400
Received: from e23smtp06.au.ibm.com ([202.81.31.148]:59943)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <prerna@linux.vnet.ibm.com>) id 1OiOAK-0003yx-Ci
	for qemu-devel@nongnu.org; Mon, 09 Aug 2010 04:57:04 -0400
Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245])
	by e23smtp06.au.ibm.com (8.14.4/8.13.1) with ESMTP id o798u0mj001274
	for <qemu-devel@nongnu.org>; Mon, 9 Aug 2010 18:56:00 +1000
Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138])
	by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o798u7Od1704168
	for <qemu-devel@nongnu.org>; Mon, 9 Aug 2010 18:56:07 +1000
Received: from d23av02.au.ibm.com (loopback [127.0.0.1])
	by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	o798u7YE010693
	for <qemu-devel@nongnu.org>; Mon, 9 Aug 2010 18:56:07 +1000
Message-ID: <4C5FC2A5.8030907@linux.vnet.ibm.com>
Date: Mon, 09 Aug 2010 14:26:05 +0530
From: Prerna Saxena <prerna@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] [Tracing] Compilation failure
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

Hi Stefan,
I think this needs to be resolved.

   CC    trace.o
   CC    simpletrace.o
cc1: warnings being treated as errors
/home/prerna/qemu-testing/git/qemu/simpletrace.c: In function=20
=91write_header=92:
/home/prerna/qemu-testing/git/qemu/simpletrace.c:46: error: integer=20
constant is too large for =91long=92 type
/home/prerna/qemu-testing/git/qemu/simpletrace.c:46: error: large=20
integer implicitly truncated to unsigned type
make: *** [simpletrace.o] Error 1

The error arises due to :
TraceRecord header =3D {
         .event =3D -1UL, /* max avoids conflicting with TraceEventIDs */
         .timestamp_ns =3D 0xf2b177cb0aa429b4, /* magic number */
			^^^^^^^^ error.

Also, it would be better to #define the magic number to some macro, and=20
use that instead of using the constant directly.

Regards,
--=20
Prerna Saxena

Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India