From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49270 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OiSQH-0008RG-Nd
	for qemu-devel@nongnu.org; Mon, 09 Aug 2010 09:29:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OiSQG-00078J-K1
	for qemu-devel@nongnu.org; Mon, 09 Aug 2010 09:29:49 -0400
Received: from mail-qw0-f45.google.com ([209.85.216.45]:59327)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OiSQG-00077m-Hm
	for qemu-devel@nongnu.org; Mon, 09 Aug 2010 09:29:48 -0400
Received: by qwh5 with SMTP id 5so23133qwh.4
	for <qemu-devel@nongnu.org>; Mon, 09 Aug 2010 06:29:47 -0700 (PDT)
Message-ID: <4C6002CB.7010007@codemonkey.ws>
Date: Mon, 09 Aug 2010 08:29:47 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] rtc: Remove TARGET_I386 from
	qemu-config.c, enables driftfix
References: <a2c3ccd27f9a2deda17604a82384ba6c2a8e354e.1277304233.git.amit.shah@redhat.com>
	<20100806111245.GA23061@redhat.com>
	<20100806204050.GA3043@amit-laptop.redhat.com>
In-Reply-To: <20100806204050.GA3043@amit-laptop.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>, Juan Quintela <quintela@redhat.com>, qemu list <qemu-devel@nongnu.org>, Jan Kiszka <jan.kiszka@web.de>, Paolo Bonzini <pbonzini@redhat.com>

On 08/06/2010 03:40 PM, Amit Shah wrote:
> On (Fri) Aug 06 2010 [12:12:45], Daniel P. Berrange wrote:
>    
>> On Wed, Jun 23, 2010 at 08:14:04PM +0530, Amit Shah wrote:
>>      
>>> qemu-config.c doesn't contain any target-specific code, and the
>>> TARGET_I386 conditional code didn't get compiled as a result. Removing
>>> this enables the driftfix parameter for rtc.
>>>
>>> Signed-off-by: Amit Shah<amit.shah@redhat.com>
>>> ---
>>>   qemu-config.c |    2 --
>>>   1 files changed, 0 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/qemu-config.c b/qemu-config.c
>>> index 95abe61..730ffd9 100644
>>> --- a/qemu-config.c
>>> +++ b/qemu-config.c
>>> @@ -247,11 +247,9 @@ QemuOptsList qemu_rtc_opts = {
>>>           },{
>>>               .name = "clock",
>>>               .type = QEMU_OPT_STRING,
>>> -#ifdef TARGET_I386
>>>           },{
>>>               .name = "driftfix",
>>>               .type = QEMU_OPT_STRING,
>>> -#endif
>>>           },
>>>           { /* end if list */ }
>>>       },
>>>        
>>
>> Is there any reason this patch hasn't been applied to GIT yet ? I'm told
>> that using this option is critical to making certain guests work reliably
>> so we want to use it from libvirt/virt-manager for the OS in question.
>>      
> Multiple pings have gone out already; I hope it's in someone's queue to
> be applied
>    

Sorry, I've got it now.  In the future, please resend patches with 
[RESEND] as opposed to just bumping it.

Regards,

Anthony Liguori

> 		Amit
>