From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49432 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OjB0t-0002zs-OW
	for qemu-devel@nongnu.org; Wed, 11 Aug 2010 09:06:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <Chris.Krumme@windriver.com>) id 1OjB0o-0005G1-Hh
	for qemu-devel@nongnu.org; Wed, 11 Aug 2010 09:06:35 -0400
Received: from mail.windriver.com ([147.11.1.11]:46768)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <Chris.Krumme@windriver.com>) id 1OjB0o-0005Ev-An
	for qemu-devel@nongnu.org; Wed, 11 Aug 2010 09:06:30 -0400
Received: from ALA-MAIL03.corp.ad.wrs.com (ala-mail03 [147.11.57.144])
	by mail.windriver.com (8.14.3/8.14.3) with ESMTP id o7BD6PpD028554
	for <qemu-devel@nongnu.org>; Wed, 11 Aug 2010 06:06:25 -0700 (PDT)
Message-ID: <4C62A050.6060502@windriver.com>
Date: Wed, 11 Aug 2010 08:06:24 -0500
From: Chris Krumme <chris.krumme@windriver.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 14/15] vnc: tight: tweak adaptive tight
	settings
References: <1281505785-22523-1-git-send-email-corentincj@iksaif.net>
	<1281505785-22523-15-git-send-email-corentincj@iksaif.net>
In-Reply-To: <1281505785-22523-15-git-send-email-corentincj@iksaif.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hello Corentin,

On 08/11/2010 12:49 AM, Corentin Chary wrote:
> The force_jpeg threshold was too low.
>
> Signed-off-by: Corentin Chary<corentincj@iksaif.net>
> ---
>   qemu-thread.c      |    1 +
>   ui/vnc-enc-tight.c |   20 ++++++++++----------
>   2 files changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/qemu-thread.c b/qemu-thread.c
> index fbc78fe..4094c51 100644
> --- a/qemu-thread.c
> +++ b/qemu-thread.c
> @@ -22,6 +22,7 @@
>   static void error_exit(int err, const char *msg)
>   {
>       fprintf(stderr, "qemu: %s: %s\n", msg, strerror(err));
> +    char *p = NULL; *p = 1;
>    

I do not believe this is the official way to do an assert.  It is also 
not documented in the change comments.

Thanks

Chris

>       exit(1);
>   }
>
> diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
> index 9f83235..b0181ff 100644
> --- a/ui/vnc-enc-tight.c
> +++ b/ui/vnc-enc-tight.c
> @@ -79,16 +79,16 @@ static const struct {
>       int jpeg_idx;               /* Allow indexed JPEG */
>       int jpeg_full;              /* Allow full color JPEG */
>   } tight_jpeg_conf[] = {
> -    { 0,   4,  1, 1 },
> -    { 0,   4,  1, 1 },
> -    { 0,   4,  1, 1 },
> -    { 0,   4,  1, 1 },
> -    { 0,   4,  0, 1 },
> -    { 0.1, 4,  0, 1 },
> -    { 0.2, 4,  0, 1 },
> -    { 0.3, 6,  0, 0 },
> -    { 0.4, 8,  0, 0 },
> -    { 0.5, 10, 0, 0 },
> +    { 0,   8,  1, 1 },
> +    { 0,   8,  1, 1 },
> +    { 0,   8,  1, 1 },
> +    { 0,   8,  1, 1 },
> +    { 0,   10, 1, 1 },
> +    { 0.1, 10, 1, 1 },
> +    { 0.2, 10, 1, 1 },
> +    { 0.3, 12, 0, 0 },
> +    { 0.4, 14, 0, 0 },
> +    { 0.5, 16, 0, 0 },
>   };
>   #endif
>
>