From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47047 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OjEjx-0006vh-9v
	for qemu-devel@nongnu.org; Wed, 11 Aug 2010 13:05:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OjEjw-0002ZY-48
	for qemu-devel@nongnu.org; Wed, 11 Aug 2010 13:05:21 -0400
Received: from mail-qy0-f173.google.com ([209.85.216.173]:60387)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OjEjw-0002ZP-26
	for qemu-devel@nongnu.org; Wed, 11 Aug 2010 13:05:20 -0400
Received: by qyk33 with SMTP id 33so382453qyk.4
	for <qemu-devel@nongnu.org>; Wed, 11 Aug 2010 10:05:19 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4C62D84C.5020405@redhat.com>
Date: Wed, 11 Aug 2010 13:05:16 -0400
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1281512334-4268-1-git-send-email-weil@mail.berlios.de>
	<1281512334-4268-2-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1281512334-4268-2-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/2] ivshmem: Fix compilation without kvm
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Cam Macdonell <cam@cs.ualberta.ca>, QEMU Developers <qemu-devel@nongnu.org>

On 08/11/2010 03:38 AM, Stefan Weil wrote:
> kvm_set_ioeventfd_mmio_long is only available with CONFIG_KVM.

We should just disable ivshmem for non-KVM

diff --git a/Makefile.target b/Makefile.target
index b791492..c8281e9 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -191,7 +191,7 @@ obj-y += rtl8139.o
  obj-y += e1000.o

  # Inter-VM PCI shared memory
-obj-y += ivshmem.o
+obj-$(CONFIG_KVM) += ivshmem.o

  # Hardware support
  obj-i386-y += vga.o

because it is also breaking Windows builds.

Alternatively, the right way to do what this patch does, is to add 
kvm_set_ioeventfd_mmio_long to kvm-stub.c, and to use 
"obj-$(CONFIG_POSIX) += ivshmem.o" in the makefile to work around the 
Windows build problems.

Paolo