From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49315 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OjFm0-0002K4-8r
	for qemu-devel@nongnu.org; Wed, 11 Aug 2010 14:11:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OjFlz-0004U9-5h
	for qemu-devel@nongnu.org; Wed, 11 Aug 2010 14:11:32 -0400
Received: from mail-qw0-f45.google.com ([209.85.216.45]:34394)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OjFlz-0004U3-1x
	for qemu-devel@nongnu.org; Wed, 11 Aug 2010 14:11:31 -0400
Received: by qwh5 with SMTP id 5so431606qwh.4
	for <qemu-devel@nongnu.org>; Wed, 11 Aug 2010 11:11:30 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4C62E7CF.80205@redhat.com>
Date: Wed, 11 Aug 2010 14:11:27 -0400
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1281512334-4268-1-git-send-email-weil@mail.berlios.de>
	<1281512334-4268-2-git-send-email-weil@mail.berlios.de>	<4C62D84C.5020405@redhat.com>
	<AANLkTikcwb1e=rz9MxbumHawuDgYWJaR34ESMhPZq=nq@mail.gmail.com>
In-Reply-To: <AANLkTikcwb1e=rz9MxbumHawuDgYWJaR34ESMhPZq=nq@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/2] ivshmem: Fix compilation without kvm
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Cam Macdonell <cam@cs.ualberta.ca>, QEMU Developers <qemu-devel@nongnu.org>

On 08/11/2010 01:18 PM, Blue Swirl wrote:
> On Wed, Aug 11, 2010 at 5:05 PM, Paolo Bonzini<pbonzini@redhat.com>  wrote:
>> On 08/11/2010 03:38 AM, Stefan Weil wrote:
>>>
>>> kvm_set_ioeventfd_mmio_long is only available with CONFIG_KVM.
>>
>> We should just disable ivshmem for non-KVM
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index b791492..c8281e9 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -191,7 +191,7 @@ obj-y += rtl8139.o
>>   obj-y += e1000.o
>>
>>   # Inter-VM PCI shared memory
>> -obj-y += ivshmem.o
>> +obj-$(CONFIG_KVM) += ivshmem.o
>>
>>   # Hardware support
>>   obj-i386-y += vga.o
>>
>> because it is also breaking Windows builds.
>>
>> Alternatively, the right way to do what this patch does, is to add
>> kvm_set_ioeventfd_mmio_long to kvm-stub.c, and to use "obj-$(CONFIG_POSIX)
>> += ivshmem.o" in the makefile to work around the Windows build problems.
>
> This patch fixes mingw32 build for me.

Looks fine.

Paolo