From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39968 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OjJSe-0003S3-C9 for qemu-devel@nongnu.org; Wed, 11 Aug 2010 18:07:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OjJSc-00071j-QD for qemu-devel@nongnu.org; Wed, 11 Aug 2010 18:07:48 -0400 Received: from mail-qw0-f45.google.com ([209.85.216.45]:42397) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OjJSc-00071f-N4 for qemu-devel@nongnu.org; Wed, 11 Aug 2010 18:07:46 -0400 Received: by qwh5 with SMTP id 5so667880qwh.4 for ; Wed, 11 Aug 2010 15:07:46 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4C631F30.6080806@redhat.com> Date: Wed, 11 Aug 2010 18:07:44 -0400 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems References: <1281550583-11908-1-git-send-email-cam@cs.ualberta.ca> <4C62EBC0.1090606@mail.berlios.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cam Macdonell Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 08/11/2010 02:32 PM, Cam Macdonell wrote: > On Wed, Aug 11, 2010 at 2:28 PM, Stefan Weil wrote: >> Am 11.08.2010 20:16, schrieb Cam Macdonell: >>> >>> --- >>> kvm-stub.c | 5 +++++ >>> 1 files changed, 5 insertions(+), 0 deletions(-) >>> >>> diff --git a/kvm-stub.c b/kvm-stub.c >>> index 3378bd3..d45f9fa 100644 >>> --- a/kvm-stub.c >>> +++ b/kvm-stub.c >>> @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr, >>> uint16_t val, bool assign) >>> { >>> return -ENOSYS; >>> } >>> + >>> +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val, bool >>> assign) >>> +{ >>> + return -ENOSYS; >>> +} >> >> Your 2nd patch disables build of ivshmem.o on non-kvm systems. >> Only ivshmem.c was using kvm_set_ioeventfd_mmio_long, so >> up to now, no dummy function in kvm-stub.c is needed. > > Right. It can be left out for now if that's preferred. No, your patch is correct. If kvm-stub.c is not complete, the build will break the next time someone uses one of those functions. Paolo