From: Avi Kivity <avi@redhat.com>
To: malc <av1474@comtv.ru>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules
Date: Sun, 15 Aug 2010 19:06:42 +0300 [thread overview]
Message-ID: <4C681092.7010800@redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1008140058060.6495@linmac>
On 08/14/2010 12:01 AM, malc wrote:
>
> This is all perfectly reasonable, but begs one question, where do we stop
> codifying self-evident truths (or who is the ultimiate judge of what is
> self-evident and what isn't), since taking the above to extreme we will
> end up adding stuff like: you must use close to dispose of open-ed
> descriptors and such like.
It's a matter of pragmatism, if a lot of patches are routinely rejected
due to some error then it makes sense to add it to CODING_STYLE, even if
they are not exactly style decisions. If not then they just dilute that
document.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-08-15 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 17:50 [Qemu-devel] [PATCH 3/5] CODING_STYLE: add memory management rules Blue Swirl
2010-08-13 19:24 ` [Qemu-devel] " Blue Swirl
2010-08-13 21:01 ` malc
2010-08-13 21:28 ` Blue Swirl
2010-08-13 21:56 ` malc
2010-08-14 10:02 ` Blue Swirl
2010-08-14 14:52 ` Andreas Färber
2010-08-15 14:07 ` Paolo Bonzini
2010-08-15 16:06 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C681092.7010800@redhat.com \
--to=avi@redhat.com \
--cc=av1474@comtv.ru \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).