From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34630 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Okfja-0006kf-Jx for qemu-devel@nongnu.org; Sun, 15 Aug 2010 12:06:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OkfjZ-0006GR-EU for qemu-devel@nongnu.org; Sun, 15 Aug 2010 12:06:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64923) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OkfjZ-0006GI-3D for qemu-devel@nongnu.org; Sun, 15 Aug 2010 12:06:53 -0400 Message-ID: <4C681092.7010800@redhat.com> Date: Sun, 15 Aug 2010 19:06:42 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: Blue Swirl , qemu-devel On 08/14/2010 12:01 AM, malc wrote: > > This is all perfectly reasonable, but begs one question, where do we stop > codifying self-evident truths (or who is the ultimiate judge of what is > self-evident and what isn't), since taking the above to extreme we will > end up adding stuff like: you must use close to dispose of open-ed > descriptors and such like. It's a matter of pragmatism, if a lot of patches are routinely rejected due to some error then it makes sense to add it to CODING_STYLE, even if they are not exactly style decisions. If not then they just dilute that document. -- error compiling committee.c: too many arguments to function