From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39676 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Okzy9-0006FV-9r
	for qemu-devel@nongnu.org; Mon, 16 Aug 2010 09:43:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1Okzy7-0006ZU-4R
	for qemu-devel@nongnu.org; Mon, 16 Aug 2010 09:43:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52494)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1Okzy6-0006Yf-Mp
	for qemu-devel@nongnu.org; Mon, 16 Aug 2010 09:43:15 -0400
Message-ID: <4C694054.8010600@redhat.com>
Date: Mon, 16 Aug 2010 15:42:44 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 02/15] xen: Add xen_machine_fv
References: <alpine.DEB.2.00.1008121244200.2545@kaball-desktop>
	<1281622202-3453-2-git-send-email-stefano.stabellini@eu.citrix.com>
In-Reply-To: <1281622202-3453-2-git-send-email-stefano.stabellini@eu.citrix.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: stefano.stabellini@eu.citrix.com
Cc: Anthony.Perard@citrix.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org

Am 12.08.2010 16:09, schrieb stefano.stabellini@eu.citrix.com:
> From: Anthony PERARD <anthony.perard@citrix.com>
> 
> Add the Xen FV (Fully Virtualized) machine to Qemu;
> this is groundwork to add Xen device model support in Qemu.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Why does this need its own machine type? Shouldn't an HVM machine really
look like a PC? And indeed most of this code looks like a (slightly
outdated) copy of pc_piix.c with !pci_enabled code paths removed.

Kevin