From: Avi Kivity <avi@redhat.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: "Yang, Sheng" <sheng.yang@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Li, Xin" <xin.li@intel.com>
Subject: [Qemu-devel] Re: [PATCH] Fix bug for vcpu hotplug
Date: Wed, 18 Aug 2010 10:33:28 +0300 [thread overview]
Message-ID: <4C6B8CC8.3040200@redhat.com> (raw)
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E164C8CB831@shsmsx502.ccr.corp.intel.com>
On 08/18/2010 10:17 AM, Liu, Jinsong wrote:
> During test, we found qemu-kvm has a bug result in guestos shutdown when vcpu hotadd.
> This patch is to fix the bug, allow hotplug for sysbus qdev.
>
> --- a/hw/qdev.c
> +++ b/hw/qdev.c
> @@ -108,6 +108,7 @@ DeviceState *qdev_create(BusState *bus, const char *name)
> if (!bus) {
> if (!main_system_bus) {
> main_system_bus = qbus_create(&system_bus_info, NULL, "main-system-bus");
> + main_system_bus->allow_hotplug = 1;
> }
> bus = main_system_bus;
> }
Looks reasonable to me.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2010-08-18 7:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BC00F5384FCFC9499AF06F92E8B78A9E0B0007F9DC@shsmsx502.ccr.corp.intel.com>
[not found] ` <4C67D844.5060306@redhat.com>
2010-08-18 7:17 ` [Qemu-devel] RE: [PATCH] Fix bug for vcpu hotplug Liu, Jinsong
2010-08-18 7:33 ` Avi Kivity [this message]
2010-08-19 15:24 ` [Qemu-devel] " Anthony Liguori
2010-08-19 15:34 ` Avi Kivity
2010-08-19 19:04 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6B8CC8.3040200@redhat.com \
--to=avi@redhat.com \
--cc=jinsong.liu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=sheng.yang@intel.com \
--cc=xin.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).