From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44045 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Old9V-0005Q3-Di
	for qemu-devel@nongnu.org; Wed, 18 Aug 2010 03:33:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1Old9U-00069F-Il
	for qemu-devel@nongnu.org; Wed, 18 Aug 2010 03:33:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13483)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1Old9U-000693-Bd
	for qemu-devel@nongnu.org; Wed, 18 Aug 2010 03:33:36 -0400
Message-ID: <4C6B8CC8.3040200@redhat.com>
Date: Wed, 18 Aug 2010 10:33:28 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <BC00F5384FCFC9499AF06F92E8B78A9E0B0007F9DC@shsmsx502.ccr.corp.intel.com>
	<4C67D844.5060306@redhat.com>
	<BC00F5384FCFC9499AF06F92E8B78A9E164C8CB831@shsmsx502.ccr.corp.intel.com>
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E164C8CB831@shsmsx502.ccr.corp.intel.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Fix bug for vcpu hotplug
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: "Yang, Sheng" <sheng.yang@intel.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "Li, Xin" <xin.li@intel.com>

  On 08/18/2010 10:17 AM, Liu, Jinsong wrote:
> During test, we found qemu-kvm has a bug result in guestos shutdown when vcpu hotadd.
> This patch is to fix the bug, allow hotplug for sysbus qdev.
>
> --- a/hw/qdev.c
> +++ b/hw/qdev.c
> @@ -108,6 +108,7 @@ DeviceState *qdev_create(BusState *bus, const char *name)
>       if (!bus) {
>           if (!main_system_bus) {
>               main_system_bus = qbus_create(&system_bus_info, NULL, "main-system-bus");
> +            main_system_bus->allow_hotplug = 1;
>           }
>           bus = main_system_bus;
>       }


Looks reasonable to me.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.