From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59502 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OllmK-0002vd-GV for qemu-devel@nongnu.org; Wed, 18 Aug 2010 12:46:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OllmF-0007sQ-Ha for qemu-devel@nongnu.org; Wed, 18 Aug 2010 12:46:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22027) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OllmF-0007sH-Aa for qemu-devel@nongnu.org; Wed, 18 Aug 2010 12:46:11 -0400 Message-ID: <4C6C0E4D.6040607@redhat.com> Date: Wed, 18 Aug 2010 19:46:05 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules References: <4C6A43B5.40809@redhat.com> <4C6AD744.1070009@twiddle.net> <4C6ADFED.5020703@redhat.com> In-Reply-To: <4C6ADFED.5020703@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Blue Swirl , qemu-devel , Richard Henderson On 08/17/2010 10:15 PM, Jes Sorensen wrote: > >> I strongly disagree. The use of "bool", even if you ignore stdbool.h >> and do "typedef int bool", is valuable documentation in the code. > I guess we have to agree to disagree then. IMHO it just masks the real > type and you end up with cases where people pass it back and forth randomly. In C99, bool is a real type. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.