From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39282 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Om0Cs-0000jd-Cj for qemu-devel@nongnu.org; Thu, 19 Aug 2010 04:10:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Om0Co-00031x-Ad for qemu-devel@nongnu.org; Thu, 19 Aug 2010 04:10:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31264) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Om0Co-00031m-17 for qemu-devel@nongnu.org; Thu, 19 Aug 2010 04:10:34 -0400 Message-ID: <4C6CE6F4.20804@redhat.com> Date: Thu, 19 Aug 2010 11:10:28 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules References: <4C6A43B5.40809@redhat.com> <4C6AD744.1070009@twiddle.net> <4C6ADFED.5020703@redhat.com> <4C6C0E4D.6040607@redhat.com> <4C6CE416.1050902@redhat.com> In-Reply-To: <4C6CE416.1050902@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Blue Swirl , qemu-devel , Richard Henderson On 08/19/2010 10:58 AM, Jes Sorensen wrote: > >> In C99, bool is a real type. > Kinda real, I would qualify it more as a pseudo type. It doesn't map to > any register size or even instruction actions. Neither do int, short, long, long long, or signed short long float. > Most processors, at least > the ones I have programmed, tend to treat it as zero == false, > everything else == true. Processors don't have _Bool. > For structure packing it's ugly. Use uint*_t for externally visible structures. use _Bool for internal booleans. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.