From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58724 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Om4ul-0005AY-Fk for qemu-devel@nongnu.org; Thu, 19 Aug 2010 09:12:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Om4uZ-00084e-Tf for qemu-devel@nongnu.org; Thu, 19 Aug 2010 09:12:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61924) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Om4uZ-00084V-Mi for qemu-devel@nongnu.org; Thu, 19 Aug 2010 09:12:03 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7JDC2lu016951 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 19 Aug 2010 09:12:02 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7JDC1FP007316 for ; Thu, 19 Aug 2010 09:12:02 -0400 Message-ID: <4C6D2DA1.2020602@redhat.com> Date: Thu, 19 Aug 2010 16:12:01 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] QEMUFileBuffered: indicate that we're ready when the underlying file is ready References: <1278521062-13795-1-git-send-email-avi@redhat.com> <4C57B364.8090500@redhat.com> <20100803100016.268293ce@redhat.com> In-Reply-To: <20100803100016.268293ce@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org On 08/03/2010 04:00 PM, Luiz Capitulino wrote: > On Tue, 03 Aug 2010 09:12:52 +0300 > Avi Kivity wrote: > >> On 07/07/2010 07:44 PM, Avi Kivity wrote: >>> QEMUFileBuffered stops writing when the underlying QEMUFile is not ready, >>> and tells its producer so. However, when the underlying QEMUFile becomes >>> ready, it neglects to pass that information along, resulting in stoppage >>> of all data until the next tick (a tenths of a second). >>> >>> Usually this doesn't matter, because most QEMUFiles used with QEMUFileBuffered >>> are almost always ready, but in the case of exec: migration this is not true, >>> due to the small pipe buffers used to connect to the target process. The >>> result is very slow migration. >>> >>> Fix by detecting the readiness notification and propagating it. The detection >>> is a little ugly since QEMUFile overloads put_buffer() to send it, but that's >>> the suject for a different patch. >> Ping. > I've queued this fix and another one in a 'for-0.13' branch and was planning > to send a pull request as soon as Anthony called for 0.13 fixes, however > this didn't happen yet and I forgot. Ping again. I don't want to take over Cam's longest-time-to-apply record, so someone apply this please. 0.13 and mainline. -- error compiling committee.c: too many arguments to function